[Top] [All Lists]

Re: [PATCH 5/5] xfs: use xfs_ialloc_blks_per_cluster in xfs_imap

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH 5/5] xfs: use xfs_ialloc_blks_per_cluster in xfs_imap
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 12 Dec 2013 10:39:38 +1100
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52A86D33.2020102@xxxxxxxxxx>
References: <52A86D33.2020102@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Dec 11, 2013 at 09:48:35PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> Use xfs_ialloc_blks_per_cluster() in xfs_imap().  Please note that we
> previously calculate the number of blocks per cluster without taking
> the situation of that the inode cluster size might be equal to or less
> than the SB blocksize into account.  Maybe there is a chance to cause
> potential issues after handling an untrusted inode number lookup and
> proceed to check if the inode number maps to a block is outsides the
> file system bounds or not.

I don't think there's any issues here - after all the inode lookups
and mapping is done, the code in xfs_imap checks that the cluster
that the inode is mapped to lies wholly within the filesystem
boundaries. Hence I think you can remove that from the patch

Otherwise, looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>