[Top] [All Lists]

Re: [PATCH 00/12] run more generic tests on TEST_DIR

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 00/12] run more generic tests on TEST_DIR
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 12 Dec 2013 09:50:12 +1100
Cc: xfs@xxxxxxxxxxx, Stanislav Kholmanskikh <stanislav.kholmanskikh@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131211073445.353655850@xxxxxxxxxxxxxxxxxxxxxx>
References: <20131211073445.353655850@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 10, 2013 at 11:34:45PM -0800, Christoph Hellwig wrote:
> As Stanislav pointed out previously various tests worked fine on NFS
> when it still defined a scratch dir that we abused for the test dir.
> This series makes various tests that don't require specific file system
> sizes or parameters run on TEST_DIR instead of using the scratch devices.
> This also allow to remove various bits of boilerplat code as the TEST_DIR
> is always available, and checked after each test.

I'm not sure this is such a good idea. The test_dir is a fixed
filesystem designed to persiste between test harness runs to allow
testing on an aged filesystem.

The scratch dev, OTOH, is used to give tests a known state before the test
begins, and to enable different filesystem configurations to be
tested easily. That is:

$ ./check -g auto


$ MKFS_OPTIONS="-b size=512" ./check -g auto

run the tests on a differently configured scratch device. I use this
all the time to change the filesystem config I'm testing against. By
moving all these tests to the TEST_DEV, these tests are no longer
run on the device that is configured specifically the way I want it
configured for the given test run.

So, I think this is a step backwards in terms of being able to
quickly iterate and cover different filesystem configurations, and
as such I don't really like it as a solution. What other options do
we have?


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>