xfs
[Top] [All Lists]

Re: [PATCH 06/10] xfstests: fix generic/225 to check fiemap support

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 06/10] xfstests: fix generic/225 to check fiemap support
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 12 Dec 2013 09:42:29 +1100
Cc: Junho Ryu <jayr@xxxxxxxxxx>, hughd@xxxxxxxxxx, tytso@xxxxxxx, branto@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131211074657.GF19248@xxxxxxxxxxxxx>
References: <1386706321-15795-1-git-send-email-jayr@xxxxxxxxxx> <1386706321-15795-7-git-send-email-jayr@xxxxxxxxxx> <20131211074657.GF19248@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 10, 2013 at 11:46:57PM -0800, Christoph Hellwig wrote:
> On Tue, Dec 10, 2013 at 12:11:57PM -0800, Junho Ryu wrote:
> > generic/225 runs fiemap.  It would be nice to call
> > _require_xfs_io_fiemap like other tests which use fiemap.
> 
> It's not exactly correct as it doesn't require xfs_io.  If you have some
> spare cycles it would be good to factor out a _require_fiemap from it.

I'd just rename if _require_fiemap, because we need both xfs_io and
kernel support for it, and we need xfs_io support to check for
kernel support....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>