xfs
[Top] [All Lists]

Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount.

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount.
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 12 Dec 2013 09:40:12 +1100
Cc: Junho Ryu <jayr@xxxxxxxxxx>, hughd@xxxxxxxxxx, tytso@xxxxxxx, branto@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131211074615.GE19248@xxxxxxxxxxxxx>
References: <1386706321-15795-1-git-send-email-jayr@xxxxxxxxxx> <1386706321-15795-6-git-send-email-jayr@xxxxxxxxxx> <20131211074615.GE19248@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 10, 2013 at 11:46:15PM -0800, Christoph Hellwig wrote:
> On Tue, Dec 10, 2013 at 12:11:56PM -0800, Junho Ryu wrote:
> > Several tests unmount then re-mount the scratch filesystem, to check
> > that the content is unchanged; but unmounting a tmpfs is designed to
> > lose its content, which causes such tests to fail unnecessarily.  Add
> > _scratch_remount(), which instead uses remount on a tmpfs to preserve
> > its contents.  Also add _test_remount() to do the same for the test
> > device.
> 
> All these tests don't make sense if you never unmount the filesystem.
> Istead they should exit with _notrun for tmpfs.

IOWs, adding tmpfs changes the definition of a "generic" test.

i.e. instead of:

_supported_fs generic

these tests are now:

_supported_fs xfs ext2 ext3 ext4 ext4dev btrfs gfs2 nfs udf reiserfs

and by that definition should be in the tests/shared directory....

That's a bit of a pain, but I really don't like the idea of having
"generic" tests that aren't actually generic by having to define
exceptions for them...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>