xfs
[Top] [All Lists]

[PATCH 2/5] xfs: use xfs_ialloc_blks_per_cluster in xfs_bulkstat

To: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Subject: [PATCH 2/5] xfs: use xfs_ialloc_blks_per_cluster in xfs_bulkstat
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Wed, 11 Dec 2013 21:48:14 +0800
Delivered-to: xfs@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
From: Jie Liu <jeff.liu@xxxxxxxxxx>

Use xfs_ialloc_blks_per_cluster() in xfs_bulkstat(), make the
related variables more meaningful and remove an unused variable
nimask from it.

Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
---
 fs/xfs/xfs_itable.c | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/fs/xfs/xfs_itable.c b/fs/xfs/xfs_itable.c
index c237ad1..6671f5b 100644
--- a/fs/xfs/xfs_itable.c
+++ b/fs/xfs/xfs_itable.c
@@ -209,9 +209,8 @@ xfs_bulkstat(
        xfs_inobt_rec_incore_t  *irbuf; /* start of irec buffer */
        xfs_inobt_rec_incore_t  *irbufend; /* end of good irec buffer entries */
        xfs_ino_t               lastino; /* last inode number returned */
-       int                     nbcluster; /* # of blocks in a cluster */
-       int                     nicluster; /* # of inodes in a cluster */
-       int                     nimask; /* mask for inode clusters */
+       int                     blks_per_cluster; /* # of blocks in a cluster */
+       int                     ninodes; /* # of inodes in a cluster */
        int                     nirbuf; /* size of irbuf */
        int                     rval;   /* return value error code */
        int                     tmp;    /* result value from btree calls */
@@ -243,11 +242,8 @@ xfs_bulkstat(
        *done = 0;
        fmterror = 0;
        ubufp = ubuffer;
-       nicluster = mp->m_sb.sb_blocksize >= XFS_INODE_CLUSTER_SIZE(mp) ?
-               mp->m_sb.sb_inopblock :
-               (XFS_INODE_CLUSTER_SIZE(mp) >> mp->m_sb.sb_inodelog);
-       nimask = ~(nicluster - 1);
-       nbcluster = nicluster >> mp->m_sb.sb_inopblog;
+       blks_per_cluster = xfs_ialloc_blks_per_cluster(mp);
+       ninodes = blks_per_cluster << mp->m_sb.sb_inopblog;
        irbuf = kmem_zalloc_greedy(&irbsize, PAGE_SIZE, PAGE_SIZE * 4);
        if (!irbuf)
                return ENOMEM;
@@ -390,12 +386,12 @@ xfs_bulkstat(
                                agbno = XFS_AGINO_TO_AGBNO(mp, r.ir_startino);
                                for (chunkidx = 0;
                                     chunkidx < XFS_INODES_PER_CHUNK;
-                                    chunkidx += nicluster,
-                                    agbno += nbcluster) {
-                                       if (xfs_inobt_maskn(chunkidx, nicluster)
+                                    chunkidx += ninodes,
+                                    agbno += blks_per_cluster) {
+                                       if (xfs_inobt_maskn(chunkidx, ninodes)
                                                        & ~r.ir_free)
                                                xfs_btree_reada_bufs(mp, agno,
-                                                       agbno, nbcluster,
+                                                       agbno, blks_per_cluster,
                                                        &xfs_inode_buf_ops);
                                }
                                blk_finish_plug(&plug);
-- 
1.8.3.2

<Prev in Thread] Current Thread [Next in Thread>