xfs
[Top] [All Lists]

Re: [PATCH 10/10] xfstests: skip parts of tests which cannot work on tmp

To: Junho Ryu <jayr@xxxxxxxxxx>
Subject: Re: [PATCH 10/10] xfstests: skip parts of tests which cannot work on tmpfs
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 10 Dec 2013 23:51:25 -0800
Cc: xfs@xxxxxxxxxxx, tytso@xxxxxxx, hughd@xxxxxxxxxx, branto@xxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1386706321-15795-11-git-send-email-jayr@xxxxxxxxxx>
References: <1386706321-15795-1-git-send-email-jayr@xxxxxxxxxx> <1386706321-15795-11-git-send-email-jayr@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 10, 2013 at 12:12:01PM -0800, Junho Ryu wrote:
> Skip generic/076 which tests concurrent access while testing tmpfs
> because there are other tests cover the case using fsstress.

Should check if SCRATCH_DEV is a block device.

> Skip generic/277 which requires chattr.

Add a feature test to see if the filesystem supports chattr.  Might
be worth to have a common _require_chattr helper chared with generic/079

> 
> Even if generic/053 will not be able to test exactly what the test has
> been intended to test, it will be still useful to have this test to try
> out some functionality on tmpfs rather than always failing or being
> skipped.

I'd rather add a simple ACL tests that covers this without the unmount
an repair and maybe more.

<Prev in Thread] Current Thread [Next in Thread>