xfs
[Top] [All Lists]

Re: [PATCH 06/10] xfstests: fix generic/225 to check fiemap support

To: Junho Ryu <jayr@xxxxxxxxxx>
Subject: Re: [PATCH 06/10] xfstests: fix generic/225 to check fiemap support
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 10 Dec 2013 23:46:57 -0800
Cc: xfs@xxxxxxxxxxx, tytso@xxxxxxx, hughd@xxxxxxxxxx, branto@xxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1386706321-15795-7-git-send-email-jayr@xxxxxxxxxx>
References: <1386706321-15795-1-git-send-email-jayr@xxxxxxxxxx> <1386706321-15795-7-git-send-email-jayr@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 10, 2013 at 12:11:57PM -0800, Junho Ryu wrote:
> generic/225 runs fiemap.  It would be nice to call
> _require_xfs_io_fiemap like other tests which use fiemap.

It's not exactly correct as it doesn't require xfs_io.  If you have some
spare cycles it would be good to factor out a _require_fiemap from it.

<Prev in Thread] Current Thread [Next in Thread>