xfs
[Top] [All Lists]

Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount.

To: Junho Ryu <jayr@xxxxxxxxxx>
Subject: Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount.
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 10 Dec 2013 23:46:15 -0800
Cc: xfs@xxxxxxxxxxx, tytso@xxxxxxx, hughd@xxxxxxxxxx, branto@xxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1386706321-15795-6-git-send-email-jayr@xxxxxxxxxx>
References: <1386706321-15795-1-git-send-email-jayr@xxxxxxxxxx> <1386706321-15795-6-git-send-email-jayr@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 10, 2013 at 12:11:56PM -0800, Junho Ryu wrote:
> Several tests unmount then re-mount the scratch filesystem, to check
> that the content is unchanged; but unmounting a tmpfs is designed to
> lose its content, which causes such tests to fail unnecessarily.  Add
> _scratch_remount(), which instead uses remount on a tmpfs to preserve
> its contents.  Also add _test_remount() to do the same for the test
> device.

All these tests don't make sense if you never unmount the filesystem.
Istead they should exit with _notrun for tmpfs.

<Prev in Thread] Current Thread [Next in Thread>