xfs
[Top] [All Lists]

Re: [PATCH 03/10] xfstests: _scratch_mkfs_sized() for tmpfs

To: Junho Ryu <jayr@xxxxxxxxxx>
Subject: Re: [PATCH 03/10] xfstests: _scratch_mkfs_sized() for tmpfs
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 10 Dec 2013 23:44:22 -0800
Cc: xfs@xxxxxxxxxxx, tytso@xxxxxxx, hughd@xxxxxxxxxx, branto@xxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1386706321-15795-4-git-send-email-jayr@xxxxxxxxxx>
References: <1386706321-15795-1-git-send-email-jayr@xxxxxxxxxx> <1386706321-15795-4-git-send-email-jayr@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 10, 2013 at 12:11:54PM -0800, Junho Ryu wrote:
> From: Hugh Dickins <hughd@xxxxxxxxxx>
> 
> _scratch_mkfs_sized() avoid blockdev and update MOUNT_OPTIONS with
> required size on tmpfs, so those tests using it can now run.
> 
> Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx>
> Signed-off-by: Junho Ryu <jayr@xxxxxxxxxx>

Ah, here we go.

>      blocks=`expr $fssize / $blocksize`
>  
> -    if [ "$HOSTOS" == "Linux" ]; then
> +    if [ "$HOSTOS" == "Linux" -a "$FSTYP" != "tmpfs" ]; then

Should just check if SCRATCH_DEV is a block devices instead of
hardcoding a filesystem.

<Prev in Thread] Current Thread [Next in Thread>