[Top] [All Lists]

Re: [PATCH v2] xfs_repair: fix process_bmbt_reclist_int

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH v2] xfs_repair: fix process_bmbt_reclist_int
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 10 Dec 2013 13:06:52 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131210205352.GC1935@xxxxxxx>
References: <20131210205352.GC1935@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 10, 2013 at 02:53:52PM -0600, Ben Myers wrote:
> There is a set checks for corruption in block map btrees in
> process_bmbt_reclist_int that we identify but currently do not fix.  It
> appears that the author's intent in this function was to set error = 1,
> and then only clear it when all of the checks were completed
> successfully.  Unfortunately error can be cleared when it is used for
> the return value of blkmap_set_ext.  Some kinds of corruption are not
> being fixed, including duplicate extents, claiming free blocks, claiming
> metadata blocks, and multiply used blocks.
> Fix this by using error2 for the return code from blkmap_set_ext.
> Signed-off-by: Ben Myers <bpm@xxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>