xfs
[Top] [All Lists]

[PATCH 10/10] xfstests: skip parts of tests which cannot work on tmpfs

To: xfs@xxxxxxxxxxx
Subject: [PATCH 10/10] xfstests: skip parts of tests which cannot work on tmpfs
From: Junho Ryu <jayr@xxxxxxxxxx>
Date: Tue, 10 Dec 2013 12:12:01 -0800
Cc: branto@xxxxxxxxxx, hughd@xxxxxxxxxx, tytso@xxxxxxx, Junho Ryu <jayr@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LfkiHxmi5LISylBiTIfgCWF7hyDSdLaMyqKjsMJfcyg=; b=DwAzGC5p5e4WvNUYk9IUz9E5IscJa76GieMap395LTNcRtW3cDnqiSvZ1piYCuJ3+T a065Q/VS/FlajdJwSWcte5Nao18bxL4/Z4niba51sG3B/J+McT0x3KG1VsYXjNIH/F3T YNod/mxMKAUM5qqdsliFB3WhLPfZfreet+OK6ouaH+rlAZ3rT8H4w3irzHmaI5K0mKFl 24jDkdt5l03TpDuX7ExnHNEv9/t+vzxCAnt6+8zClwQ9vQ9Ce/gxmsZnDyZpfi6QkiHP W2bjfyBRTDYrQsEJ0vR3sjLV8hjRhzcAaP82ub3CHqHv2je0VzyOMro5kkc7z4rXXALq qetw==
In-reply-to: <1386706321-15795-1-git-send-email-jayr@xxxxxxxxxx>
References: <1386706321-15795-1-git-send-email-jayr@xxxxxxxxxx>
Skip generic/076 which tests concurrent access while testing tmpfs
because there are other tests cover the case using fsstress.

Skip generic/277 which requires chattr.

Even if generic/053 will not be able to test exactly what the test has
been intended to test, it will be still useful to have this test to try
out some functionality on tmpfs rather than always failing or being
skipped.

Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx>
Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
Signed-off-by: Junho Ryu <jayr@xxxxxxxxxx>
---
 tests/generic/053 | 6 +++---
 tests/generic/076 | 2 ++
 tests/generic/277 | 2 ++
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/tests/generic/053 b/tests/generic/053
index b8bd9e6..885b87c 100755
--- a/tests/generic/053
+++ b/tests/generic/053
@@ -81,9 +81,9 @@ list_acls()
 
 echo "acls before repair:"
 list_acls
-_do 'unmount $SCRATCH_DEV' 'umount $SCRATCH_DEV'
-_do 'repair filesystem' '_check_scratch_fs'
-_do 'mount filesytem' '_scratch_mount'
+_do 'unmount $SCRATCH_DEV' '[ $FSTYP = tmpfs ] || umount $SCRATCH_DEV'
+_do 'repair filesystem' '[ $FSTYP = tmpfs ] || _check_scratch_fs'
+_do 'mount filesytem' '[ $FSTYP = tmpfs ] || _scratch_mount'
 echo "acls after repair: "
 list_acls
 
diff --git a/tests/generic/076 b/tests/generic/076
index a53840f..faeed2f 100755
--- a/tests/generic/076
+++ b/tests/generic/076
@@ -57,6 +57,8 @@ _supported_os IRIX Linux
 
 _require_scratch
 
+[ "$FSTYP" = "tmpfs" ] && _notrun "not applicable for the tmpfs file system"
+
 echo "*** init fs"
 
 rm -f $seqres.full
diff --git a/tests/generic/277 b/tests/generic/277
index 8461ad9..4672343 100755
--- a/tests/generic/277
+++ b/tests/generic/277
@@ -44,6 +44,8 @@ _supported_fs generic
 _supported_os Linux
 _require_scratch
 
+[ "$FSTYP" = "tmpfs" ] && _notrun "not applicable for the tmpfs file system"
+
 _scratch_mkfs > /dev/null 2>&1
 _scratch_mount
 
-- 
1.8.5.1

<Prev in Thread] Current Thread [Next in Thread>