xfs
[Top] [All Lists]

Re: [PATCH 01/10] xfs: remove duplicate code in xlog_cil_insert_format_i

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 01/10] xfs: remove duplicate code in xlog_cil_insert_format_items
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 10 Dec 2013 08:18:27 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131209194548.GX1935@xxxxxxx>
References: <20131129083919.207915844@xxxxxxxxxxxxxxxxxxxxxx> <20131129084000.123386171@xxxxxxxxxxxxxxxxxxxxxx> <20131209194548.GX1935@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Dec 09, 2013 at 01:45:48PM -0600, Ben Myers wrote:
> > +                   if (ordered) {
> > +                           /* track as an ordered logvec */
> > +                           ASSERT(lip->li_lv == NULL);
> > +                           lv->lv_buf_len = XFS_LOG_VEC_ORDERED;
> > +                           goto insert;
> 
> It looks like lv->lv_niovecs is no longer being set in this case.  Was that 
> intentional?

Yes, ordered log vecs don't have iovecs attached, so the implicit zero
from the kmem_zalloc is the right value.

<Prev in Thread] Current Thread [Next in Thread>