xfs
[Top] [All Lists]

Re: [PATCH 06/10] xfs: format log items write directly into the linear C

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 06/10] xfs: format log items write directly into the linear CIL buffer
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 10 Dec 2013 08:12:23 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131209190028.GW1935@xxxxxxx>
References: <20131129083919.207915844@xxxxxxxxxxxxxxxxxxxxxx> <20131129084001.028583376@xxxxxxxxxxxxxxxxxxxxxx> <20131204003712.GE10988@dastard> <20131209190028.GW1935@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Dec 09, 2013 at 01:00:28PM -0600, Ben Myers wrote:
> > And if we need to guarantee alignment, then maybe roundup here to
> > ensure we don't end up with bad offsets?  That would require padding
> > the allocation of the buffer to take it into account, too....
> > 
> > Other than this concern, the code looks fine.
> 
> Christoph, what about this alignment issue?

I think Dave is right, but I haven't had time to look at the issue in
detail and respin the patchset yet.

<Prev in Thread] Current Thread [Next in Thread>