[Top] [All Lists]

Re: nfs vs xfstests 193

To: "J. Bruce Fields" <bfields@xxxxxxxxxxxx>
Subject: Re: nfs vs xfstests 193
From: Stanislav Kholmanskikh <stanislav.kholmanskikh@xxxxxxxxxx>
Date: Tue, 10 Dec 2013 18:43:51 +0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Vasily Isaenko <vasily.isaenko@xxxxxxxxxx>, linux-nfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, "Sachin S. Prabhu" <sprabhu@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131206204747.GB12613@xxxxxxxxxxxx>
References: <20131106115648.GA24804@xxxxxxxxxxxxx> <52A1CF22.106@xxxxxxxxxx> <20131206180858.GA2803@xxxxxxxxxxxxx> <20131206204404.GA12613@xxxxxxxxxxxx> <20131206204747.GB12613@xxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131030 Thunderbird/17.0.10

On 12/07/2013 12:47 AM, J. Bruce Fields wrote:
On Fri, Dec 06, 2013 at 03:44:04PM -0500, bfields wrote:
On Fri, Dec 06, 2013 at 10:08:58AM -0800, Christoph Hellwig wrote:
On Fri, Dec 06, 2013 at 05:20:34PM +0400, Stanislav Kholmanskikh wrote:
Just to make the behaviour more consistent between NFS and other
"local" file systems as It was done by

Seems like we got others in line with XFS behavior.

But, not having tested the behavior, it looks like fs/open.c has a
simlar !S_ISDIR() check.  Where's that behavior implemented?

I'd prefer to have NFS follow this as well.

Huh.  Sachin, do you remember if there was any other motivation behind
that patch?

Never mind, I see, the complaint is about the case where the id's don't
change, not about the directory case.  So Sachin's
0953e620de0538cbd081f1b45126f6098112a598 doesn't actually have anything
to do with this.

I'm fine with removing the id comparisons and changing the nfsd behavior
to match local filesystems.


I will try to produce a patch for this.


xfs mailing list

<Prev in Thread] Current Thread [Next in Thread>