xfs
[Top] [All Lists]

Re: [PATCH 04/11] xfs: add xfs_ilock_attr_map_shared

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 04/11] xfs: add xfs_ilock_attr_map_shared
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 9 Dec 2013 16:30:52 -0600
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131209222433.GY10988@dastard>
References: <20131206203006.914776999@xxxxxxxxxxxxxxxxxxxxxx> <20131206203128.663030833@xxxxxxxxxxxxxxxxxxxxxx> <20131208223610.GE31386@dastard> <20131209181612.GA22183@xxxxxxxxxxxxx> <20131209222433.GY10988@dastard>
User-agent: Mutt/1.5.20 (2009-06-14)
Dave,

On Tue, Dec 10, 2013 at 09:24:33AM +1100, Dave Chinner wrote:
> On Mon, Dec 09, 2013 at 10:16:12AM -0800, Christoph Hellwig wrote:
> > On Mon, Dec 09, 2013 at 09:36:10AM +1100, Dave Chinner wrote:
> > > > +                       /*
> > > > +                        * Even after flushing the inode, there can 
> > > > still be
> > > > +                        * delalloc blocks on the inode beyond EOF due 
> > > > to
> > > > +                        * speculative reallocation.  These are not 
> > > > removed
> > > 
> > > "speculative preallocation"
> > 
> > I just re-indented the comment, the wording is the original one.  Maybe
> > we'll get a commit that cares enought to fix it on the fly..
> 
> Actually, I checked that before commenting on it - the original
> comment is correct:
> 
>  626                 /*
>  627                  * even after flushing the inode, there can still be 
> delalloc
>  628                  * blocks on the inode beyond EOF due to speculative
>  629                  * preallocation. These are not removed until the release
>  630                  * function is called or the inode is inactivated. Hence 
> we
>  631                  * cannot assert here that ip->i_delayed_blks == 0.
>  632                  */
> 
> I wouldn't have pointed at it if the original code had that
> problem... :/

If you want to extend your Reviewed-by: on this patch I will clean up the
spelling mistake and pull in this series.

-Ben

<Prev in Thread] Current Thread [Next in Thread>