[Top] [All Lists]

Re: [PATCH 03/11] xfs: rename xfs_ilock_map_shared

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 03/11] xfs: rename xfs_ilock_map_shared
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 8 Dec 2013 23:03:16 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131208223359.GD31386@dastard>
References: <20131206203006.914776999@xxxxxxxxxxxxxxxxxxxxxx> <20131206203128.511935311@xxxxxxxxxxxxxxxxxxxxxx> <20131208223359.GD31386@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Dec 09, 2013 at 09:33:59AM +1100, Dave Chinner wrote:
> While we are changing this, I think it makes sense to move it to
> being a static inline function given how simple it is....

I actually tried that first, but with XFS_DINODE_FMT_BTREE in
fs/xfs/xfs_dinode.h, struct xfsicdinode in xfs_log_format.h
and the resulting dependencies it didn't seem workable.  My inode
reshuffle might provide relief eventually.

<Prev in Thread] Current Thread [Next in Thread>