xfs
[Top] [All Lists]

Re: [PATCH 05/11] xfs: reinstate the ilock in xfs_readdir

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/11] xfs: reinstate the ilock in xfs_readdir
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 9 Dec 2013 09:36:28 +1100
Cc: xfs@xxxxxxxxxxx, Ben Myers <bpm@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131206203128.786826439@xxxxxxxxxxxxxxxxxxxxxx>
References: <20131206203006.914776999@xxxxxxxxxxxxxxxxxxxxxx> <20131206203128.786826439@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Dec 06, 2013 at 12:30:11PM -0800, Christoph Hellwig wrote:
> From: Ben Myers <bpm@xxxxxxx>
> 
> Although it was removed in commit 051e7cd44ab8, ilock needs to be taken in
> xfs_readdir because we might have to read the extent list in from disk.  This
> keeps other threads from reading from or writing to the extent list while it 
> is
> being read in and is still in a transitional state.
> 
> This has been associated with "Access to block zero" messages on directories
> with large numbers of extents resulting from excessive filesytem 
> fragmentation,
> as well as extent list corruption.  Unfortunately no test case at this point.
> 
> Signed-off-by: Ben Myers <bpm@xxxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>