xfs
[Top] [All Lists]

[PATCH 0/2] misc log recovery patches

To: xfs@xxxxxxxxxxx
Subject: [PATCH 0/2] misc log recovery patches
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 06 Dec 2013 15:20:27 -0600
Delivered-to: xfs@xxxxxxxxxxx
User-agent: quilt/0.51-1
A couple log recovery patches.

patch 1 is a correction to commit:
        commit 2a84108fe275f95fbe838b1c92b7c45258dcae5c
        Author: Mark Tinguely <tinguely@xxxxxxx>
        Date:   Wed Oct 2 07:51:12 2013 -0500
        xfs: free the list of recovery items on error

Errors in phase 1/2 of xlog_recover_commit_trans will free the
transaction pointer and the new call to xlog_recover_process_data
will reuse and refree the pointer. I missed it in testing of the
2a84108 patch. Found by Dan Carpenter and verified by forcing an
error in xlog_recover_process_data.

        ---

patch 2 is the second version of the patch to remove the EFI from
the AIL when log recovery of the EFI item fails. If the EFI entry is
not removed from the AIL, then xfs_ail_push_all_sync will hang while
doing the forced shutdown. I moved the removal of all EFIs from the
AIL to the caller, xlog_recover_process_efis to catch all the errors
coming from xlog_recover_process_efi. This bug was found and verified
using a metadata dump of a filesystem that has an error freeing an
extent.

Mark.

<Prev in Thread] Current Thread [Next in Thread>