xfs
[Top] [All Lists]

Re: [Cluster-devel] [PATCH 16/18] gfs2: use generic posix ACL infrastruc

To: Steven Whitehouse <swhiteho@xxxxxxxxxx>
Subject: Re: [Cluster-devel] [PATCH 16/18] gfs2: use generic posix ACL infrastructure
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 6 Dec 2013 11:47:20 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, viro@xxxxxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1386159157.2711.11.camel@menhir>
References: <20131201115903.910559036@xxxxxxxxxxxxxxxxxxxxxx> <20131201120656.539995924@xxxxxxxxxxxxxxxxxxxxxx> <1386159157.2711.11.camel@menhir>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Dec 04, 2013 at 12:12:37PM +0000, Steven Whitehouse wrote:
> >             error = posix_acl_equiv_mode(acl, &mode);
> > +           if (error < 0)
> >  
> Andy Price has pointed out a missing "return error;" here
> 
> > -           if (error <= 0) {
> > -                   posix_acl_release(acl);
> > +           if (error == 0)
> >                     acl = NULL;
> >  
> > -                   if (error < 0)
> > -                           return error;
> > -           }
> > -
> 
> Also, there seems to be a white space error in the xfs patch around line
> 170 in fs/xfs/xfs_iops.c where there is an added "if (default_acl)" with
> a space before the tab,

I'll take care of these for the next version.

<Prev in Thread] Current Thread [Next in Thread>