| To: | Stanislav Kholmanskikh <stanislav.kholmanskikh@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests: stop special casing nfs and udf |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 6 Dec 2013 08:06:58 -0800 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <52A175DD.5050908@xxxxxxxxxx> |
| References: | <20131107204635.GA22954@xxxxxxxxxxxxx> <52A175DD.5050908@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Fri, Dec 06, 2013 at 10:59:41AM +0400, Stanislav Kholmanskikh wrote: > Sorry for my post-commit "review". > > But for what purposes did you delete this scratch device handling for nfs? > Now each test case that uses _require_scratch returns [not run]. > > It means most of the generic/ test cases. > > I think we should revert this part of code. How do you think? Tests really requiring a scratch device don't make sense for XFS, as the scratch device is supposed to get recreated for every test. However it seems like a lot of tests should simply run on the test device. I'll take care of moving them over to use the test device. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | re: xfs: free the list of recovery items on error, Dan Carpenter |
|---|---|
| Next by Date: | Re: xfs: free the list of recovery items on error, Mark Tinguely |
| Previous by Thread: | Re: [PATCH] xfstests: stop special casing nfs and udf, Stanislav Kholmanskikh |
| Next by Thread: | ××××× ××, ×××× ××× |
| Indexes: | [Date] [Thread] [Top] [All Lists] |