xfs
[Top] [All Lists]

Re: [PATCH] fs: fix iversion handling

To: Chris Mason <clm@xxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] fs: fix iversion handling
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 5 Dec 2013 16:37:25 -0600
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131204220144.1501.13481@ret>
References: <20131119151707.GA13412@xxxxxxxxxxxxx> <20131204212504.GX1935@xxxxxxx> <20131204220144.1501.13481@ret>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Dec 04, 2013 at 05:01:44PM -0500, Chris Mason wrote:
> Quoting Ben Myers (2013-12-04 16:25:04)
> > Hey Christoph,
> > 
> > On Tue, Nov 19, 2013 at 07:17:07AM -0800, Christoph Hellwig wrote:
> > > Currently notify_change directly updates i_version for size updates,
> > > which not only is counter to how all other fields are updated through
> > > struct iattr, but also breaks XFS, which need inode updates to happen
> > > under its own lock, and synchronized to the structure that gets written
> > > to the log.
> > > 
> > > Remove the update in the common code, and it to btrfs and ext4,
> > > XFS already does a proper updaste internally and currently gets a
> > > double update with the existing code.
> > > 
> > > IMHO this is 3.13 and -stable material and should go in through the XFS
> > > tree.
> > > 
> > > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> > 
> > Does this still need a btrfs ack, or is it ready to go?
> 
> The btrfs parts look good to me.
> 
> Signed-off-by: Chris Mason <clm@xxxxxx>

Great.  Applied to the xfs tree as per Christoph's suggestion.

<Prev in Thread] Current Thread [Next in Thread>