xfs
[Top] [All Lists]

Re: [PATCH] fs: fix iversion handling

To: Ben Myers <bpm@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] fs: fix iversion handling
From: Chris Mason <clm@xxxxxx>
Date: Wed, 4 Dec 2013 17:01:44 -0500
Cc: <linux-fsdevel@xxxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=content-type : mime-version : content-transfer-encoding : to : from : in-reply-to : cc : references : message-id : subject : date; s=facebook; bh=R9jjIutEDaGyAfJYTdt+PgifwwVF2BQ5j72fYODkqBk=; b=YCFvJdShWXrH2DxqBNbgeNUoW2u/9fTxzFZEzoLSXGnRN5B0qPTE1KkUkPytImjZJmrk 0Jiip0EjnAm9GZXi//Uh1dPiy8QaYm3XKE0XE24BYcR7mk0heu6WJnj5vbMBfW7YCOV+ G/LFQBKpD1MxYxuAkDaljui0Ah1dHNVqprI=
In-reply-to: <20131204212504.GX1935@xxxxxxx>
References: <20131119151707.GA13412@xxxxxxxxxxxxx> <20131204212504.GX1935@xxxxxxx>
User-agent: alot/0.3.5
Quoting Ben Myers (2013-12-04 16:25:04)
> Hey Christoph,
> 
> On Tue, Nov 19, 2013 at 07:17:07AM -0800, Christoph Hellwig wrote:
> > Currently notify_change directly updates i_version for size updates,
> > which not only is counter to how all other fields are updated through
> > struct iattr, but also breaks XFS, which need inode updates to happen
> > under its own lock, and synchronized to the structure that gets written
> > to the log.
> > 
> > Remove the update in the common code, and it to btrfs and ext4,
> > XFS already does a proper updaste internally and currently gets a
> > double update with the existing code.
> > 
> > IMHO this is 3.13 and -stable material and should go in through the XFS
> > tree.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Does this still need a btrfs ack, or is it ready to go?

The btrfs parts look good to me.

Signed-off-by: Chris Mason <clm@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>