| To: | Mark Tinguely <tinguely@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/2] xfs free the list of recovery items on error. |
| From: | Ben Myers <bpm@xxxxxxx> |
| Date: | Wed, 4 Dec 2013 14:51:05 -0600 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20131002125409.930462395@xxxxxxx> |
| References: | <20131002125110.745269864@xxxxxxx> <20131002125409.930462395@xxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Wed, Oct 02, 2013 at 07:51:12AM -0500, Mark Tinguely wrote: > Recovery builds a list of items on the transaction's > r_itemq head. Normally these items are committed and freed. > But in the event of a recovery error, these allocations > are leaked. > > If the error occurs during item reordering, then reconstruct > the r_itemq list before deleting the list to avoid leaking > the entries that were on one of the temporary lists. > > Signed-off-by: Mark Tinguely <tinguely@xxxxxxx> Looks good to me. Reviewed-by: Ben Myers <bpm@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs_repair: suggest reboot after dangerous repair, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH v3] xfs: fix memory leak in xfs_dir2_node_removename, Ben Myers |
| Previous by Thread: | Re: [PATCH] xfs_repair: suggest reboot after dangerous repair, Ben Myers |
| Next by Thread: | Re: [PATCH 2/2] xfs free the list of recovery items on error., Ben Myers |
| Indexes: | [Date] [Thread] [Top] [All Lists] |