xfs
[Top] [All Lists]

Re: [PATCH] xfs_repair: suggest reboot after dangerous repair

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH] xfs_repair: suggest reboot after dangerous repair
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Wed, 04 Dec 2013 13:42:42 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131204193822.GU1935@xxxxxxx>
References: <52826206.3080106@xxxxxxxxxx> <20131204193822.GU1935@xxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.1.1
On 12/4/13, 1:38 PM, Ben Myers wrote:
> On Tue, Nov 12, 2013 at 11:14:46AM -0600, Eric Sandeen wrote:
>> If a "dangerous" repair (repair of a readonly mounted fs)
>> has been done, suggest an immediate reboot upon completion.
>>
>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
>> ---
>>
>> TBH, I don't know how "dangerous" dangerous is.  Is this
>> still required?
> 
> Was there a crash or something after a repair that led to
> this patch?
> 
> Reviewed-by: Ben Myers <bpm@xxxxxxx>
> 

No, it was generated by a "bug" saying that it was impossible
to run fsck.xfs on a root filesystem.

That was largely an RTFM kind of thing but since it's normal
for some systems to come up w/ RO-root in rescue mode, and people
are used to being able to run e2fsck in that mode, it might be worth
adding a little help to our tool to accomplish the same thing.

-Eric

<Prev in Thread] Current Thread [Next in Thread>