xfs
[Top] [All Lists]

Re: [PATCH 08/10] xfs: remove the inode log format from the inode log it

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 08/10] xfs: remove the inode log format from the inode log item
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 4 Dec 2013 11:44:38 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131129084001.431063269@xxxxxxxxxxxxxxxxxxxxxx>
References: <20131129083919.207915844@xxxxxxxxxxxxxxxxxxxxxx> <20131129084001.431063269@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Nov 29, 2013 at 12:39:27AM -0800, Christoph Hellwig wrote:
> No need to keep the inode log format around all the time, we can easily
> generate it at iop_format time.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Ignoring the previously mentioned structure alignment issue, this
change looks good. Overall, the inode log item is reduced in size by
about 72 bytes. :)

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 08/10] xfs: remove the inode log format from the inode log item, Dave Chinner <=