[Top] [All Lists]

Re: [PATCH] xfstests: stop special casing nfs and udf

To: Rich Johnston <rjohnston@xxxxxxx>
Subject: Re: [PATCH] xfstests: stop special casing nfs and udf
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 4 Dec 2013 10:30:17 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <529DDE2D.3000501@xxxxxxx>
References: <20131107204635.GA22954@xxxxxxxxxxxxx> <20131122091553.GA32568@xxxxxxxxxxxxx> <20131202174045.GA21861@xxxxxxxxxxxxx> <20131202232549.GV8803@dastard> <20131202233629.GM1935@xxxxxxx> <20131203042936.GY8803@dastard> <529DDE2D.3000501@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 03, 2013 at 07:35:41AM -0600, Rich Johnston wrote:
> On 12/02/2013 10:29 PM, Dave Chinner wrote:
> >On Mon, Dec 02, 2013 at 05:36:30PM -0600, Ben Myers wrote:
> >Hence if a developer sends a ping to remind the maintainers about a
> >reviewed patch that has been sitting around, then I'm going to do
> >something about it straight away...
> My apologies to Christoph. I missed that I thought he was waiting
> for a review, not a commit from me.

One of the roles of a maintainer is to review code when nobody
else steps up to do it. So rather than wait for someone else to
review the code, you should do it yourself, wait 24-48 for any
responses once you give it a Reviewed-by tag, and then you can
commit it.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>