xfs
[Top] [All Lists]

Re: [RFC PATCH] xfs: fix calculation of freed inode cluster blocks

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [RFC PATCH] xfs: fix calculation of freed inode cluster blocks
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 4 Dec 2013 08:28:14 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131203210054.GN1935@xxxxxxx>
References: <20131203210054.GN1935@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 03, 2013 at 03:00:54PM -0600, Ben Myers wrote:
> rec.ir_startino is an agino rather than an ino.  Use the correct macro
> when dealing with it in xfs_difree.
> 
> ---
> 
> This is very lightly tested so it's RFC.  Looks like using "ino to
> agbno" is actually harmless when you pass in an agino, so there
> shouldn't have been any trouble caused by this one.

Right, the XFS_INO_TO_AGBNO() macro will behave correctly when
passed an agino - it's the same as an inode from AG 0. Changing the
macro to the correct one is effectively a no-op, so just send a
patch and get it reviewed and integrated...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>