[Top] [All Lists]

Re: [PATCH] xfstests: stop special casing nfs and udf

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH] xfstests: stop special casing nfs and udf
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 3 Dec 2013 15:29:36 +1100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131202233629.GM1935@xxxxxxx>
References: <20131107204635.GA22954@xxxxxxxxxxxxx> <20131122091553.GA32568@xxxxxxxxxxxxx> <20131202174045.GA21861@xxxxxxxxxxxxx> <20131202232549.GV8803@dastard> <20131202233629.GM1935@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Dec 02, 2013 at 05:36:30PM -0600, Ben Myers wrote:
> On Tue, Dec 03, 2013 at 10:25:49AM +1100, Dave Chinner wrote:
> > On Mon, Dec 02, 2013 at 09:40:45AM -0800, Christoph Hellwig wrote:
> > > On Fri, Nov 22, 2013 at 01:15:53AM -0800, Christoph Hellwig wrote:
> > > > ping?
> > > 
> > > ping^2?
> > 
> > I just got write access to the XFS git repos on oss.sgi.com, so I'll
> > start hoovering up all the outstanding xfstests patches as a
> > shakedown pass before I touch anything else...
> You might want to chat with Rich.  There may be some already in progress.

I've already pushed the ones I found last week on the list.

FYI, I've been waiting for repo write perms to be able to push them
since wednesday last week. Rich hasn't said anything on the mailing
list or on IRC in that time, so I can only conclude that he's off
doing something else.

Handling xfstests patches in a manner necessary for upstream commit
is something I've already integrated into my day-to-day workflow. As
such, I'm able to push reviewed patches at almost any time (within
reason - next day is best for everyone) at almost zero cost to me.
That cost will go down as I script and optimise my workflow.

If other developers don't want me to do this, let them speak up.

However, as a maintainer, I'm not happy with leaving reviewed
patches on the list for weeks before commiting them. As a developer,
there is nothing more frsutrating that having to continually remind
the maintainer that they need to commit a patch.

Hence if a developer sends a ping to remind the maintainers about a
reviewed patch that has been sitting around, then I'm going to do
something about it straight away...


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>