xfs
[Top] [All Lists]

Re: [PATCH 02/10] xfs: refactor xfs_buf_item_format_segment

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 02/10] xfs: refactor xfs_buf_item_format_segment
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 3 Dec 2013 12:03:10 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131129084000.310003388@xxxxxxxxxxxxxxxxxxxxxx>
References: <20131129083919.207915844@xxxxxxxxxxxxxxxxxxxxxx> <20131129084000.310003388@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Nov 29, 2013 at 12:39:21AM -0800, Christoph Hellwig wrote:
> Add two helpers to make the code more readable.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good. Much easier to understand split out like this, so thanks
for doing that.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 02/10] xfs: refactor xfs_buf_item_format_segment, Dave Chinner <=