xfs
[Top] [All Lists]

Re: [PATCH 2/3] xfstests: Introduce xfs/323 to verify turn group/project

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH 2/3] xfstests: Introduce xfs/323 to verify turn group/project quotas off
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 3 Dec 2013 11:45:13 +1100
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52983C48.50007@xxxxxxxxxx>
References: <52983C48.50007@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Nov 29, 2013 at 03:03:36PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> Introduce xfs/323 to verify that turn group/project quotas off
> while user quotas is on.
> 
> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>

One minor thing:

> +# Modify as appropriate.
> +_supported_fs xfs
> +_supported_os Linux
> +
> +_require_scratch
> +_require_xfs_quota
> +_require_xfs_crc_sb
> +
> +_qmount_option "uquota,gquota,pquota"
> +_qmount
> +
> +TESTDIR=$SCRATCH_MNT/testdir

Too similar to TEST_DIR. "quota_dir", or something like it, so
people don't get confused by what device this test is running on at
a glance.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 2/3] xfstests: Introduce xfs/323 to verify turn group/project quotas off, Dave Chinner <=