xfs
[Top] [All Lists]

Re: [PATCH 15/15] mkfs: don't treat files as though they are block devic

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 15/15] mkfs: don't treat files as though they are block devices
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 2 Dec 2013 09:24:41 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1385689430-10103-16-git-send-email-david@xxxxxxxxxxxxx>
References: <1385689430-10103-1-git-send-email-david@xxxxxxxxxxxxx> <1385689430-10103-16-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
>  void
>  platform_flush_device(int fd, dev_t device)
>  {
> -     if (major(device) != RAMDISK_MAJOR)
> +     struct stat64   st;
> +     if (major(device) == RAMDISK_MAJOR)
> +             return;
> +
> +     if (fstat64(fd, &st) < 0)
> +             return;
> +
> +     if (S_ISREG(st.st_mode))
> +             fsync(fd);
> +     else
>               ioctl(fd, BLKFLSBUF, 0);
>  }

Given that fsync does the right thing for device on Linux aswell
I'd suggest we make this function call it all the time and get rid
of all the ramdisk magic.

Should probabbly be a a separate patch.

<Prev in Thread] Current Thread [Next in Thread>