Re: [PATCH 11/15] mkfs: table based parsing for converted parameters

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Fri, Nov 29, 2013 at 12:43:46PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> All the parameters that can be passed as block or sector sizes need
> to be passed the block and sector sizes that they should be using
> for conversion. For parameter parsing, it is always the same two
> variables, so to make things easy just declare them as global
> variables so we can avoid needing to pass them to getnum_checked().
> 
> We also need to mark these parameters are requiring conversion so
> that we don't need to pass this information manually to
> getnum_checked(). Further, some of these options are required to
> have a power of 2 value, so add optional checking for that as well.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>


Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>