| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 10/15] mkfs: add respecification detection to generic parsing |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 2 Dec 2013 09:15:39 -0800 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1385689430-10103-11-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1385689430-10103-1-git-send-email-david@xxxxxxxxxxxxx> <1385689430-10103-11-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
> -const struct opt_params bopts = {
> +struct opt_params bopts = {
Maybe you shouldn't have added these consts in the first place :)
Otherwise looks good,
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 09/15] mkfs: use getnum_checked for all ranged parameters, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 11/15] mkfs: table based parsing for converted parameters, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 09/15] mkfs: use getnum_checked for all ranged parameters, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 11/15] mkfs: table based parsing for converted parameters, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |