xfs
[Top] [All Lists]

Re: [PATCH 08/15] mkfs: getbool is redundant

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 08/15] mkfs: getbool is redundant
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 2 Dec 2013 09:12:06 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1385689430-10103-9-git-send-email-david@xxxxxxxxxxxxx>
References: <1385689430-10103-1-git-send-email-david@xxxxxxxxxxxxx> <1385689430-10103-9-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Nov 29, 2013 at 12:43:43PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> getbool() can be replaced with getnum_checked with appropriate
> min/max values set for the boolean variables.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 08/15] mkfs: getbool is redundant, Christoph Hellwig <=