Re: [PATCH 07/15] mkfs: structify input parameter passing

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

> +     const char      name;
> +     const char      *subopts[MAX_SUBOPTS];
> +     struct subopt_param {
> +             int             index;
> +             long long       minval;
> +             long long       maxval;
> +     }               subopt_params[MAX_SUBOPTS];
> +};

Any reason to have a separate array for subopts instead of
moving it into struct subopt_param?

Except for that I really like the approach!

Reviewed-by: Christoph Hellwig <hch@xxxxxx>