xfs
[Top] [All Lists]

Re: [PATCH 07/15] mkfs: structify input parameter passing

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 07/15] mkfs: structify input parameter passing
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 2 Dec 2013 09:11:03 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1385689430-10103-8-git-send-email-david@xxxxxxxxxxxxx>
References: <1385689430-10103-1-git-send-email-david@xxxxxxxxxxxxx> <1385689430-10103-8-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> +     const char      name;
> +     const char      *subopts[MAX_SUBOPTS];
> +     struct subopt_param {
> +             int             index;
> +             long long       minval;
> +             long long       maxval;
> +     }               subopt_params[MAX_SUBOPTS];
> +};

Any reason to have a separate array for subopts instead of
moving it into struct subopt_param?

Except for that I really like the approach!

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>