xfs
[Top] [All Lists]

Re: inode_permission NULL pointer dereference in 3.13-rc1

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: inode_permission NULL pointer dereference in 3.13-rc1
From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Date: Thu, 28 Nov 2013 16:26:18 +0000
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131127100906.GA19740@xxxxxxxxxxxxx>
References: <20131124140413.GA19271@xxxxxxxxxxxxx> <20131124152758.GL10323@xxxxxxxxxxxxxxxxxx> <20131125160648.GA4933@xxxxxxxxxxxxx> <20131126131134.GM10323@xxxxxxxxxxxxxxxxxx> <20131126141253.GA28062@xxxxxxxxxxxxx> <20131127064351.GN10323@xxxxxxxxxxxxxxxxxx> <20131127100906.GA19740@xxxxxxxxxxxxx>
Sender: Al Viro <viro@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 27, 2013 at 02:09:06AM -0800, Christoph Hellwig wrote:

> Also if you want to look me into something else feel free - it's very
> reproducable here.  Wish I could be more help here, but with all the
> RCU and micro optimizations in the path lookup code I can't claim to
> really understand it anymore.

OK, I've been able to reproduce it and I see at least a part of what's
going on, but...

What happens is that we get path_init() race with something and leave
us with nd->path pointing to what used to be pwd but has become a
negative dentry in process.

AFAICS, it *was* borderline possible to hit before now:

process A and B are CLONE_FS threads and are chdired to /tmp/foo
A asks for e.g. readlink() on bar
        in path_init() we'd got nd->path (at /tmp/foo) and nd->seq; we are
        in LOOKUP_RCU mode, so nd->path isn't pinned.
B chdirs them both to /tmp, leaving /tmp/foo not busy
C rmdirs /tmp/foo
A sets nd->inode to nd->path.dentry->d_inode, but this sucker has gone
negative now.  Sure, nd->seq doesn't match anymore, but that doesn't
do us any good - the first thing we'll do in link_path_walk() is
may_lookup(nd) and it'll blow on attempt to call inode_permission() for
nd->inode.

What I still do not understand is how the devil is similar race actually
triggered during shutdown.  Digging through that right now...

Anyway, verifying that this is what's going on for particular reproducer
is easy - add WARN_ON(!nd->inode) in the very end of path_init() and
see if it triggers.

<Prev in Thread] Current Thread [Next in Thread>