xfs
[Top] [All Lists]

Re: [PATCH v2 2/3] xfs: fix infinite loop by detaching the group/project

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH v2 2/3] xfs: fix infinite loop by detaching the group/project hints from user dquot
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 28 Nov 2013 02:43:36 -0800
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5294A469.1060000@xxxxxxxxxx>
References: <5294A469.1060000@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Nov 26, 2013 at 09:38:49PM +0800, Jeff Liu wrote:
> +     if (flags & XFS_QMOPT_UQUOTA)
> +             return xfs_qm_dqpurge(dqp, NULL);

To me it doesn't make any sense to overload this function for the user
quotas that don't have hints.

I'd suggest dropping this hunk and keeping a separate walk for
releasing the uquots. 

<Prev in Thread] Current Thread [Next in Thread>