xfs
[Top] [All Lists]

Re: [PATCH v2] xfstests,btrfs: add wrong compress type regression test

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2] xfstests,btrfs: add wrong compress type regression test
From: Miao Xie <miaox@xxxxxxxxxxxxxx>
Date: Tue, 26 Nov 2013 15:01:46 +0800
Cc: xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131126064107.GN8803@dastard>
References: <20131125210055.GG8803@dastard> <1385445677-27762-1-git-send-email-miaox@xxxxxxxxxxxxxx> <20131126064107.GN8803@dastard>
Reply-to: miaox@xxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On tue, 26 Nov 2013 17:41:07 +1100, Dave Chinner wrote:
> On Tue, Nov 26, 2013 at 02:01:17PM +0800, Miao Xie wrote:
>> Btrfs would crash when the users wrote some data into a file with compress
>> flag but the compression of the fs was disabled. This test case is to check
>> this bug still happen or not.
>>
>> Signed-off-by: Miao Xie <miaox@xxxxxxxxxxxxxx>
>> ---
>> Changlog v1 -> v2:
>> - address the commit from Dave Chinner.
> 
> Testing every change before posting them for review is a good habit
> to develop. This:
> 
>> +    $XFS_IO_PROG -f -c "pwrite 0 1M" -c sync $work_file | _filter_xfs_io
> 
> will dump this:
> 
> wrote 1048576/1048576 bytes at offset 0
> XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> command "sync" not found
> 
> into the output file and hence the test will fail as the golden
> image file in the patch was not updated to match the new test output.
> 
> It also points out that "-c sync" command is invalid - the
> command to fsync a file is "-c fsync".

Sorry for my miss, please review the 3th one.

Thanks
Miao

> 
> Cheers,
> 
> Dave.
> 

<Prev in Thread] Current Thread [Next in Thread>