xfs
[Top] [All Lists]

Re: [PATCH] xfstests,btrfs: add wrong compress type regression test

To: Miao Xie <miaox@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests,btrfs: add wrong compress type regression test
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 26 Nov 2013 08:00:55 +1100
Cc: linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1385375324-11019-1-git-send-email-miaox@xxxxxxxxxxxxxx>
References: <1385375324-11019-1-git-send-email-miaox@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Nov 25, 2013 at 06:28:44PM +0800, Miao Xie wrote:
> A test to check if the oops will happen when the users write some
> data into the files whose compress flag is set but the compression
> of the fs is disabled.
> 
> Signed-off-by: Miao Xie <miaox@xxxxxxxxxxxxxx>
> ---
>  tests/btrfs/022     | 82 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/btrfs/022.out |  5 ++++
>  tests/btrfs/group   |  1 +
>  3 files changed, 88 insertions(+)
>  create mode 100755 tests/btrfs/022
>  create mode 100644 tests/btrfs/022.out
> 
> diff --git a/tests/btrfs/022 b/tests/btrfs/022
> new file mode 100755
> index 0000000..0755fb5
> --- /dev/null
> +++ b/tests/btrfs/022
> @@ -0,0 +1,82 @@
> +#! /bin/bash
> +# FS QA Test No. btrfs/008
> +#
> +# btrfs wrong compression type regression test, from a user report on
> +# linux-btrfs.

That doesn't tell me what is being tested. The commit message above
is what should be here.

> +#
> +#-----------------------------------------------------------------------
> +# Copyright (c) 2013 Fujitsu.  All Rights Reserved.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it would be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write the Free Software Foundation,
> +# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
> +#
> +#-----------------------------------------------------------------------
> +#
> +
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +
> +status=1     # failure is the default!
> +
> +_cleanup()
> +{
> +     rm -f $tmp.*
> +}
> +
> +trap "_cleanup ; exit \$status" 0 1 2 3 15
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# real QA test starts here
> +_supported_fs btrfs
> +_supported_os Linux
> +_require_scratch
> +
> +__workout()
> +{
> +     work_file="$SCRATCH_MNT/tmpfile"
> +
> +     touch $work_file || _fail "failed create test file"
> +     chattr =c $work_file || _fail "failed change attribute of test file"
> +     dd if=/dev/zero of=$work_file bs=1M count=1 oflag=sync &> /dev/null
> +     if [ $? -ne 0 ]; then
> +             _fail "failed write data into the test file"
> +     fi

There is no need to run _fail on all of these commands. If touch
fails, it will emit an error that will end up in the output file,
and the golden output match will fail and the diff will tell you
exactly what the error was.

Also, xfs_io is preferable to using dd, and filtering the output
into the output file will give error detection and reporting, just
like for touch and chattr....

__workout()
{
        work_file="$SCRATCH_MNT/tmpfile"

        touch $work_file
        chattr =c $work_file
        $XFS_IO_PROG -f -c "pwrite 0 1M" -c sync $work_file | _filter_xfs_io
}

> +echo "*** test nodatacow"
> +_scratch_mkfs > /dev/null 2>&1
> +_scratch_mount "-o nodatacow"
> +__workout
> +_scratch_unmount

_check_scratch_fs?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>