xfs
[Top] [All Lists]

Re: [PATCH 5/7] xfs: defer EFI and EFD log formatting until iop_format t

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH 5/7] xfs: defer EFI and EFD log formatting until iop_format time
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 24 Nov 2013 01:18:30 -0800
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131123151534.204073240@xxxxxxxxxxxxxxxxxxxxxx>
References: <20131123151151.716201348@xxxxxxxxxxxxxxxxxxxxxx> <20131123151534.204073240@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Nov 23, 2013 at 07:11:56AM -0800, Christoph Hellwig wrote:
> No need to allocate large chunks of memory to format each extent into
> an array when logging the EFI or EFD items.  Instead just point to the
> bmap free list and only generate the log format at iop_format time.
> 
> Also get rid of the now almost empty xfs_trans_extfree.c by merging it
> into xfs_extfree_item.c.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Turns out this version can fairly easily cause use after frees, so it'll
need a bit of an overhaul to get the lifetime rules right.  As I have
other things in that area in the queue consider patches 5 to 7 withdrawn
for now, they will be submitted as a separate series once ready.

<Prev in Thread] Current Thread [Next in Thread>