xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix assertion failure at xfs_setattr_nonsize

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix assertion failure at xfs_setattr_nonsize
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 22 Nov 2013 07:38:58 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <528F796F.6070601@xxxxxxxxxx>
References: <528F743D.9010800@xxxxxxxxxx> <20131122151735.GA2405@xxxxxxxxxxxxx> <528F796F.6070601@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Nov 22, 2013 at 11:34:07PM +0800, Jeff Liu wrote:
> On 11/22 2013  23:17 PM, Christoph Hellwig wrote:
> > On Fri, Nov 22, 2013 at 11:11:57PM +0800, Jeff Liu wrote:
> >> To remain the current semantics under the debug mode, this fix add
> >> an additional judgement to make this assertion only works for non-CRC
> >> enabled version.
> > 
> >>            if (!gid_eq(igid, gid)) {
> >>                    if (XFS_IS_QUOTA_RUNNING(mp) && XFS_IS_GQUOTA_ON(mp)) {
> >> -                          ASSERT(!XFS_IS_PQUOTA_ON(mp));
> >> +#ifdef DEBUG quota
> >> +                          if (!xfs_sb_version_has_pquotino(&mp->m_sb))
> >> +                                  ASSERT(!XFS_IS_PQUOTA_ON(mp));
> >> +#endif
> >>                            ASSERT(mask & ATTR_GID);
> >>                            ASSERT(gdqp);
> > 
> > I'd just kill this assert.
> I hesitated about killing this assertion or hold the line before, will fix it 
> soon.

If we want to keep it maybe write is a little nicer:

        ASSERT(xfs_sb_version_has_pquotino(&mp->m_sb) ||
               !XFS_IS_PQUOTA_ON(mp));

<Prev in Thread] Current Thread [Next in Thread>