xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix assertion failure at xfs_setattr_nonsize

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix assertion failure at xfs_setattr_nonsize
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 22 Nov 2013 07:17:35 -0800
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <528F743D.9010800@xxxxxxxxxx>
References: <528F743D.9010800@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Nov 22, 2013 at 11:11:57PM +0800, Jeff Liu wrote:
> To remain the current semantics under the debug mode, this fix add
> an additional judgement to make this assertion only works for non-CRC
> enabled version.

>               if (!gid_eq(igid, gid)) {
>                       if (XFS_IS_QUOTA_RUNNING(mp) && XFS_IS_GQUOTA_ON(mp)) {
> -                             ASSERT(!XFS_IS_PQUOTA_ON(mp));
> +#ifdef DEBUG
> +                             if (!xfs_sb_version_has_pquotino(&mp->m_sb))
> +                                     ASSERT(!XFS_IS_PQUOTA_ON(mp));
> +#endif
>                               ASSERT(mask & ATTR_GID);
>                               ASSERT(gdqp);

I'd just kill this assert.  And it would be good to get some coverage
of running with all three quotas types into xfstests by default..

<Prev in Thread] Current Thread [Next in Thread>