xfs
[Top] [All Lists]

Re: [PATCH RFC] xfs: set block device logical sector size on xfs_buftarg

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH RFC] xfs: set block device logical sector size on xfs_buftarg
From: Ric Wheeler <rwheeler@xxxxxxxxxx>
Date: Fri, 22 Nov 2013 09:26:43 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131122142022.GC14680@xxxxxxxxxxxxx>
References: <5283C41D.7070503@xxxxxxxxxx> <20131113185645.GA20869@xxxxxxxxxxxxx> <5283CE2E.2070702@xxxxxxxxxxx> <20131113212658.GJ6188@dastard> <20131114133749.GA26268@xxxxxxxxxxxxx> <5284E484.6090001@xxxxxxxxxxx> <20131114210156.GP6188@dastard> <528F66A4.7060200@xxxxxxxxxx> <20131122142022.GC14680@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0
On 11/22/2013 09:20 AM, Christoph Hellwig wrote:
On Fri, Nov 22, 2013 at 09:13:56AM -0500, Ric Wheeler wrote:
I think you do that by using SCSI debug to get a 4K sector drive -
that is how we tested for RHEL6 for example.  Layering on
restrictions to hardware in the file system seems a bit harsh.

The QEMU crowd will be working to get better support for 4K drives
in the future, but I think that we are effectively going to cause a
huge field issue here since these 512/4K drives are extremely
common..

Given the SCSI debug method for this, does that mean you retract
your objections and will support Eric's patch :) ?
We actually have a test for 4k drives using scsi_debug in xfstests: xfs/279.


Just to add on here. we are going to work more closely with the kvm/qemu people to make sure that they properly take care of the hints about alignment and so on (thanks to you for putting that in!).

Ric

<Prev in Thread] Current Thread [Next in Thread>