On 11/22 2013 17:18, Christoph Hellwig wrote:
> On Fri, Nov 22, 2013 at 02:04:00PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@xxxxxxxxxx>
>> In xfs_qm_scall_trunc_qfiles(), we ignore the error if failed to remove
>> the users quota metadata and proceed to remove groups and projects if
>> they are being there. However, in user space, the remove operation will
>> break and return if failed to remove any kind of quota.
>> Also for v5 super block, we can enabled both group and project quota at
>> the same time, in this case the current error handling will cover the
>> group error with projects but they might failed due to different reasons.
>> It seems we'd better the error handling consistent to the user space and
>> don't trying to remove another kind of quota metadata if the previous
>> operation is failed.
> Looks good. Just curious, did you manage to reproduce an error
> truncating the quota files?
Yup, I thought it over how to break it while occasionally glanced over this
function for backporting upstream patches this morning, but can not figure
out a simple method.