xfs
[Top] [All Lists]

Re: [PATCH] xfstests: xfs/322, verify xfs_quota administrator commands a

To: Eryu Guan <guaneryu@xxxxxxxxx>
Subject: Re: [PATCH] xfstests: xfs/322, verify xfs_quota administrator commands against invalid mount path
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Fri, 22 Nov 2013 17:12:46 +0800
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131122085000.GD10132@xxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <528F0D82.7010607@xxxxxxxxxx> <20131122085000.GD10132@xxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 11/22 2013 16:50, Eryu Guan wrote:
> On Fri, Nov 22, 2013 at 03:53:38PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@xxxxxxxxxx>
>>
>> Introduce xfs/322 to verify xfs_quota administrator commands can
>> deal with invalid XFS mount path properly without NULL pointer
>> dereference issue.
>>
>> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
>> ---
>>  tests/xfs/322     | 68 
>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  tests/xfs/322.out |  2 ++
>>  tests/xfs/group   |  1 +
>>  3 files changed, 71 insertions(+)
>>  create mode 100755 tests/xfs/322
>>  create mode 100644 tests/xfs/322.out
>>
>> diff --git a/tests/xfs/322 b/tests/xfs/322
>> new file mode 100755
>> index 0000000..9c749a1
>> --- /dev/null
>> +++ b/tests/xfs/322
>> @@ -0,0 +1,68 @@
>> +#! /bin/bash
>> +# FS QA Test No. 322
>> +#
>> +# Test to verify xfs_quota(8) administrator commands can deal with invalid
>> +# storage mount point without NULL pointer dereference problem.
>> +#
>> +#-----------------------------------------------------------------------
>> +# Copyright (c) 2013 Oracle Inc.  All Rights Reserved.
>> +#
>> +# This program is free software; you can redistribute it and/or
>> +# modify it under the terms of the GNU General Public License as
>> +# published by the Free Software Foundation.
>> +#
>> +# This program is distributed in the hope that it would be useful,
>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +# GNU General Public License for more details.
>> +#
>> +# You should have received a copy of the GNU General Public License
>> +# along with this program; if not, write the Free Software Foundation,
>> +# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
>> +#-----------------------------------------------------------------------
>> +#
>> +
>> +seq=`basename $0`
>> +seqres=$RESULT_DIR/$seq
>> +echo "QA output created by $seq"
>> +
>> +here=`pwd`
>> +tmp=/tmp/$$
>> +status=1    # failure is the default!
>> +trap "_cleanup; exit \$status" 0 1 2 3 15
>> +
>> +_cleanup()
>> +{
>> +    cd /
>> +    rm -f $tmp.*
>> +}
>> +
>> +# get standard environment, filters and checks
>> +. ./common/rc
>> +. ./common/filter
>> +
>> +# real QA test starts here
>> +
>> +# Modify as appropriate.
> 
> This comment is not needed.
> 
>> +_supported_fs generic
> 
> Should be "_supported_fs xfs" ?
Oops, exactly. Looks I have to refresh my head after completing a tedious task.

Thanks,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>