xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs/quota: fix NULL pointer dereference in report_f

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs/quota: fix NULL pointer dereference in report_f
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Sat, 16 Nov 2013 10:54:08 +0800
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52863F99.7050808@xxxxxxxxxx>
References: <52849CC5.10109@xxxxxxxxxx> <20131114140916.GA13501@xxxxxxxxxxxxx> <52857BEB.4010406@xxxxxxxxxx> <20131115140928.GB17561@xxxxxxxxxxxxx> <52863F99.7050808@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 11/15 2013 23:36 PM, Jeff Liu wrote:
> On 11/15 2013 22:09, Christoph Hellwig wrote:
>> On Fri, Nov 15, 2013 at 09:42:03AM +0800, Jeff Liu wrote:
>>> As per a rough tryout while fixing this problem, it seems that most of those
>>> functions are just not be invoked since other precheck-ups were failed 
>>> before
>>> calling them.  We have another old fix for stat_f():
>>
>> Most or all?  If this is the only case I'm fine with putting your
>> patch in a quick fix, even if I'd prefer the version I suggested for
>> the long run.
> Most.  I'm in the middle of this check because I found another critical
> bug in kernel quota management which can cause xfs_quota hang up, it can
> 100% reproducible but still under investigation.
Sorry for the delay!  I can not find more problems.

AFAICS, there are 6 administrator commands dereference fs_path for further
operation, i.e, free, path, limit, quot, state, report.
Except report, state has already been fixed with fs_path precheck-up, the
others are safe as additional precheck-ups failed.

Thanks,
-Jeff


<Prev in Thread] Current Thread [Next in Thread>