xfs
[Top] [All Lists]

[PATCH 6/6] jfs: simplify lmLogSync() via list_last_entry_or_null()

To: linux-kernel@xxxxxxxxxxxxxxx
Subject: [PATCH 6/6] jfs: simplify lmLogSync() via list_last_entry_or_null()
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Fri, 15 Nov 2013 12:35:15 +0800
Cc: akpm@xxxxxxxxxxxxxxxxxxxx, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, cluster-devel@xxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, oleg@xxxxxxxxxx, jiri@xxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
From: Jie Liu <jeff.liu@xxxxxxxxxx>

Simplify the code in lmLogSync() via list_last_entry_or_null().

Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
---
 fs/jfs/jfs_logmgr.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index 7b565d0..2f90779 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -963,13 +963,9 @@ static int lmLogSync(struct jfs_log * log, int hard_sync)
 
        if (log->sync == log->syncpt) {
                LOGSYNC_LOCK(log, flags);
-               if (list_empty(&log->synclist))
-                       log->sync = log->lsn;
-               else {
-                       lp = list_entry(log->synclist.next,
-                                       struct logsyncblk, synclist);
-                       log->sync = lp->lsn;
-               }
+               lp = list_last_entry_or_null(&log->synclist, struct logsyncblk,
+                                            synclist);
+               log->sync = lp ? lp->lsn : log->lsn;
                LOGSYNC_UNLOCK(log, flags);
 
        }
-- 
1.8.3.2

<Prev in Thread] Current Thread [Next in Thread>