xfs
[Top] [All Lists]

[PATCH 5/6] jfs: simplify lmNextPage() via list_last_entry_or_null()

To: linux-kernel@xxxxxxxxxxxxxxx
Subject: [PATCH 5/6] jfs: simplify lmNextPage() via list_last_entry_or_null()
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Fri, 15 Nov 2013 12:34:44 +0800
Cc: akpm@xxxxxxxxxxxxxxxxxxxx, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, cluster-devel@xxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, oleg@xxxxxxxxxx, jiri@xxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
From: Jie Liu <jeff.liu@xxxxxxxxxx>

Simplify the code in lmNextPage via list_last_entry_or_null().

Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
---
 fs/jfs/jfs_logmgr.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index 360d27c..7b565d0 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -591,10 +591,7 @@ static int lmNextPage(struct jfs_log * log)
         *      write or queue the full page at the tail of write queue
         */
        /* get the tail tblk on commit queue */
-       if (list_empty(&log->cqueue))
-               tblk = NULL;
-       else
-               tblk = list_entry(log->cqueue.prev, struct tblock, cqueue);
+       tblk = list_last_entry_or_null(&log->cqueue, struct tblock, cqueue);
 
        /* every tblk who has COMMIT record on the current page,
         * and has not been committed, must be on commit queue
-- 
1.8.3.2

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 5/6] jfs: simplify lmNextPage() via list_last_entry_or_null(), Jeff Liu <=