xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: Fix stray semicolon in libxfs/rdwr.c

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: Fix stray semicolon in libxfs/rdwr.c
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 15 Nov 2013 08:04:06 +1100
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5285386A.8020800@xxxxxxxxxx>
References: <5285386A.8020800@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Nov 14, 2013 at 02:54:02PM -0600, Eric Sandeen wrote:
> The commit:
> 
> 800db1c1 libxfs: refactor libxfs_buf_read_map for xfs_db
> 
> introduced a stray semicolon during the refactoring.  Luckily it
> only breaks the error case.
> 
> (Caught by Coverity, CID 1128894)

My fault, but really, this is something that gcc should warn about
because it's almost always a bug....

> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
> index 0aa2eba..0219a08 100644
> --- a/libxfs/rdwr.c
> +++ b/libxfs/rdwr.c
> @@ -754,7 +754,7 @@ libxfs_readbufr_map(struct xfs_buftarg *btp, struct 
> xfs_buf *bp,
>               offset += len;
>       }
>  
> -     if (!error);
> +     if (!error)
>               bp->b_flags |= LIBXFS_B_UPTODATE;
>  #ifdef IO_DEBUG
>       printf("%lx: %s: read %u bytes, error %d, blkno=0x%llx(0x%llx), %p\n",

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>