xfs
[Top] [All Lists]

Re: [PATCH RFC] xfs: set block device logical sector size on xfs_buftarg

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH RFC] xfs: set block device logical sector size on xfs_buftarg
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 15 Nov 2013 08:01:56 +1100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5284E484.6090001@xxxxxxxxxxx>
References: <5283C41D.7070503@xxxxxxxxxx> <20131113185645.GA20869@xxxxxxxxxxxxx> <5283CE2E.2070702@xxxxxxxxxxx> <20131113212658.GJ6188@dastard> <20131114133749.GA26268@xxxxxxxxxxxxx> <5284E484.6090001@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Nov 14, 2013 at 08:56:04AM -0600, Eric Sandeen wrote:
> On 11/14/13, 7:37 AM, Christoph Hellwig wrote:
> > On Thu, Nov 14, 2013 at 08:26:58AM +1100, Dave Chinner wrote:
> >> Seems like that's the avenue for improvement here to me. i.e. expose
> >> the correct values to the guest so it's mkfs does the right thing.
> >> Or, alternatively, make qemu buffer non-aligned/sized IOs itself
> >> internally.
> > 
> > I've implemented the support to expose these to the guest in qemu
> > years ago.  But the problem remains that this is information which
> > needs to be attached to the image, which can't really work with raw
> > images, and no one has bother to implement the support to store it
> > for say qcow2.
> > 
> 
> Ok but once again - this is not a guest mkfs issue.  The reported
> problem is that the guest cannot _boot_ in cache=none mode because
> the bios attempts a 512-byte DIO.

A different viewpoint: How can we make sure real 4k sector hardware
works with Linux when it comes along if we can't emulate it via
qemu + virtualisation?

People often use qemu + virutalisation as a method of testing code
for hardware they don't have access to, and this just seems like
another of those things that we should have working in this
environment long before real hardware comes along and requires it...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>